Repository navigation
Conversation
…on fetch fails Carries the real Hedera-format transaction id from wherever it's already known (list row, a prior successful load, or transaction creation) into the fetch-failure toast and log, falling back to the local id only when no real id is available. Also navigates back to the previous transactions tab (or the default tab) on an initial-load failure instead of leaving the page stuck on an infinite loader. Signed-off-by: John Bair <john.bair@swirldslabs.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 224 224
Lines 7032 7034 +2
Branches 1302 1297 -5
=======================================
+ Hits 7031 7033 +2
Misses 1 1 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Three active moderate issues remain: retry flows can report a stale transaction ID, notification-triggered fetch failures lack user-facing errors, and initial-load redirects can use a stale transactions tab.
3 open issues
What changed in this PR
This pull request carries the real Hedera transaction ID through navigation so transaction-fetch failures show meaningful identifiers, include structured logging, and return users to the transactions view after an initial-load failure.
Changes:
- Adds optional SDK transaction IDs to transaction navigation state and route query parameters.
- Propagates real IDs from transaction lists, groups, and transaction creation flows.
- Adds fetch-failure logging, ID fallback handling, redirect recovery, and comprehensive tests.
| File | Description |
|---|---|
| front-end/src/tests/renderer/stores/storeNextTransactionV2.spec.ts | Tests transaction ID propagation through navigation and route query parameters. |
| front-end/src/tests/renderer/pages/Transactions/components/TransactionNodeTable.spec.ts | Tests transaction-row navigation with real transaction IDs. |
| front-end/src/tests/renderer/pages/Transactions/components/History.spec.ts | Tests real ID propagation for local and organization history navigation. |
| front-end/src/tests/renderer/pages/TransactionGroupDetails/TransactionGroupRow.spec.ts | Updates group-row navigation event expectations for real transaction IDs. |
| front-end/src/tests/renderer/pages/TransactionGroupDetails/TransactionGroupDetails.spec.ts | Tests real transaction ID propagation through group details navigation. |
| front-end/src/tests/renderer/pages/TransactionDetails/TransactionDetails.spec.ts | Tests fetch-failure messaging, structured logging, fallback IDs, and redirects. |
| front-end/src/tests/renderer/components/Transaction/Create/BaseTransaction/BaseTransaction.spec.ts | Tests transaction ID propagation after creation and local storage. |
| front-end/src/renderer/stores/storeNextTransactionV2.ts | Carries optional SDK transaction IDs through transaction navigation routes. |
| front-end/src/renderer/pages/Transactions/components/TransactionNodeTable.vue | Passes real transaction IDs from transaction list rows into navigation. |
| front-end/src/renderer/pages/Transactions/components/History.vue | Passes real transaction IDs from local and organization history entries. |
| front-end/src/renderer/pages/TransactionGroupDetails/TransactionGroupRow.vue | Emits the real transaction ID when opening a group transaction. |
| front-end/src/renderer/pages/TransactionGroupDetails/TransactionGroupDetails.vue | Preserves real transaction IDs during group-detail navigation and sibling traversal. |
| front-end/src/renderer/pages/TransactionDetails/TransactionDetails.vue | Reports fetch failures with meaningful IDs and structured context, then redirects after initial failure. |
| front-end/src/renderer/components/Transaction/Create/BaseTransaction/BaseTransaction.vue | Carries transaction IDs from transaction creation into detail navigation. |
Review effort: Lite
| const targetNodeId: TransactionNodeId = { transactionId: id }; | ||
| const targetNodeId: TransactionNodeId = { | ||
| transactionId: id, | ||
| sdkTransactionId: transaction.value.transactionId?.toString(), |
| // an infinite loader. Toast manually since catching here stops it from reaching the global | ||
| // onErrorCaptured handler. | ||
| toastManager.error(getErrorMessage(error, 'An error occurred')); | ||
| await redirectToPreviousTransactionsTab(router); |
Comment on lines
+374
to
+375
| toastManager.error(getErrorMessage(error, 'An error occurred')); | ||
| await redirectToPreviousTransactionsTab(router); |
…id in the toast Wraps the whole fetch in one handler that logs dbId and sdkTransactionId; the toast uses the real id or a generic contact-admin message. Also logs the initial-load redirect and signature key failures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: John Bair <john.bair@swirldslabs.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: John Bair <john.bair@swirldslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
0.0.x@seconds.nanos) from wherever it's already known — a list row, a prior successful load of the same transaction, or transaction creation — into the fetch-failure toast and log, instead of showing the meaningless local DB id. Falls back to the local id only when no real id is known yet (e.g. a direct deep link).Test plan
vue-tsctypecheck passesmaincheckout)Fixes #3785